Pros, cons, and mitigation strategies of solo founder vs. co-founding, courtesy of @noamwass (The Founder’s Dilemma): pic.twitter.com/KJ5cVtse1H
I’ve reviewed over 750 PR’s at AWS. As my team’s tech lead I provide insightful feedback and enforce a high code quality bar. But as a jr engineer I couldn’t review code. I didn’t know where to start, what to look for or how to comment. Here’s how I review PR’s. 🧵 👇
- Agree with notes on how to do this well, although I think the PR process is outdated & inefficient. Everything below is important long term, but I would take a review that brings the functionality & UX up to par over one that makes code more readable. With advent of PR apps (Heroku & Netlify), it'd be cool to see UX/usability also becoming part of code review.
- Code reviews purpose:
- Coaching opportunity.
- Strengthen readability & system understanding.
- Read code deeply to get a good understanding.
- "avoid using “you” or “your."
- "prefix nitpicks with “nit.”
- "I approve when and only when the PR is good enough."
Read More
Hide